Shahar Havivi has posted comments on this change.
Change subject: add/del network - add bridgesless network ......................................................................
Patch Set 8: (11 inline comments)
.................................................... File vdsm/API.py Line 1086: options['bridged'] = bridged I am removing this code and passing it in the options{}
Line 1101: options['bridged'] = bridged the same...
.................................................... File vdsm/clientIF.py Line 118: configNetwork.createLibvirtNetwork(network, True, None) Done
.................................................... File vdsm_cli/vdsClient.py Line 1391: bridge = params.get('bridge', '') this is not my code, the is bridge and bridged ie bridge=bridgename and bridged=True/False any way it will be pass in options so I will discard the changes in this file
.................................................... File vdsm/configNetwork.py Line 264: if _isTrue(bridged): Done
Line 508: if _isTrue(bridged): Done
Line 583: skipLibvirt = _isTrue(options.get('skipLibvirt', False)) I will do it in a different patch, this need to be tested
Line 591: _addNetworkValidation(_netinfo, bridge=network if _isTrue(bridged) else None, vlan=vlan, bonding=bonding, nics=nics, Done
Line 614: if _isTrue(bridged): Done
Line 626: if not bonding and _isTrue(bridged): Done
.................................................... File vdsm/netinfo.py Line 57: def bridgeless(): I wanted it to be the same as vlans(), bridgeless() methods
-- To view, visit http://gerrit.ovirt.org/848 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com