Dan Kenigsberg has posted comments on this change.
Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
wouldn't the correct approach be NOT to try to download the certificate ahead of time if it is not required for fingerprint validation?
.................................................... File vdsm_reg/deployUtil.py Line 1361: help="Invalidaterhevm certificate so that consequent RHEVM registrations will fail") Invalidate RHEV-M
-- To view, visit http://gerrit.usersys.redhat.com/779 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Alan Pevec apevec@redhat.com Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Yotam Oron yoron@redhat.com