Juan Hernandez has posted comments on this change.
Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
I think this is a good step forward. I would suggest to add a comment to the vdsm-elevator.sh script explaining the current limitations (modifies all devices, modifies dm devices, etc) so we can remember later to improve it.
.................................................... File vdsm/storage/vdsm-elevator.sh Line 3: elevator="$1" Line 4: scheduler="/sys/${DEVPATH}/queue/scheduler" Line 5: Line 6: if [ -w "${scheduler}" ]; then Line 7: echo "${elevator}" > "${scheduler}" Why the extra space after > ?
-- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Fabian Deutsch fabiand@fedoraproject.org Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com