Timothy Asir has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume ......................................................................
Patch Set 8:
(2 comments)
.................................................... File client/vdsClientGluster.py Line 457: params = self._eqSplit(args) Line 458: volumeName = params.get('volumeName', '') Line 459: if not volumeName: Line 460: raise ValueError('volumeName is required parameter') Line 461: This check is not required! Line 462: status = self.s.glusterVolumeStatsInfoGet(volumeName) Line 463: pp.pprint(status) Line 464: return status['status']['code'], status['status']['message'] Line 465:
.................................................... File vdsm/gluster/statvfs.py Line 43: log.debug("Mount point for volume %s: %s" % (volumeName, mountPoint)) Line 44: fs = "%s:/%s" % (volumeServer, volumeName) Line 45: glusterfsMount = storage.mount.Mount(fs, mountPoint) Line 46: try: Line 47: glusterfsMount.mount(vfstype="glusterfs") There will be some potential security risk when we mount the volume in /tmp. Please check it out and try to mount the volume in read only mode under privilaged user (path). Line 48: except storage.mount.MountError: Line 49: removeMountPoint(mountPoint) Line 50: raise ge.GlusterVolumeStatsInfoGetFailedException(vol=volumeName) Line 51: