Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
......................................................................
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61482/13/tests/utilsTests.py
File tests/utilsTests.py:
Line 1060: self._noIntrWatchFd(myPipe, isEpoll=False, mask=select.POLLIN)
Line 1061: proc.join()
Line 1062:
Line 1063:
Line 1064: class AtomicFileWriteTest(TestCaseBase):
Please add a test with an exception and check that the temp file is cleaned.
Line 1065:
Line 1066: def test_create_a_new_file(self):
Line 1067: TEXT = 'foo'
Line 1068: with namedTemporaryDir() as tmp_dir:
--
To view, visit
https://gerrit.ovirt.org/61482
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes