Haim Ateya has posted comments on this change.
Change subject: BZ#705058 - StoragePool instanciations should be lock protected. ......................................................................
Patch Set 3:
tested this change as a part of change 717 and this change seem to break vdsm initialization on cleanup stage;
Thread-11::ERROR::2011-07-19 12:02:04,240::hsm::175::Storage.HSM::(storageRefresh) Unexpected error Traceback (most recent call last): File "/usr/share/vdsm/storage/hsm.py", line 169, in storageRefresh vars.task.getSharedLock(STORAGE, spUUID) AttributeError: 'thread._local' object has no attribute 'task'
-- To view, visit http://gerrit.usersys.redhat.com/700 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ad3cdb07299d63203db98ae3223559b6fdc4eab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yotam Oron yoron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yotam Oron yoron@redhat.com