Dan Kenigsberg has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27262/2//COMMIT_MSG
Commit Message:
Line 33: 240.0.0.0/24 via 240.0.0.1 dev test-network
Line 34: default via 240.0.0.254 dev test-network
Line 35: broadcast 127.255.255.255 dev lo proto kernel scope link src 127.0.0.1
Line 36: broadcast 240.0.0.255 dev test-network proto kernel scope link src
240.0.0.1
Line 37: local 10.34.60.31 dev eth1 proto kernel scope host src 10.34.60.31
With the pains of
http://gerrit.ovirt.org/27236 fresh in mind, Assaf comment is worth
relating to. It is a shame to parse all the rules if iproute2 can give us only the one
relevant
It seems quite simple to exclude "local" routes from the specific table - why
not do it?
Line 38: local 240.0.0.1 dev test-network proto kernel scope host src 240.0.0.1
Line 39: broadcast 240.0.0.0 dev test-network proto kernel scope link src
240.0.0.1
Line 40: broadcast 10.34.60.0 dev eth1 proto kernel scope link src 10.34.60.31
Line 41: broadcast 10.34.63.255 dev eth1 proto kernel scope link src 10.34.60.31
--
To view, visit
http://gerrit.ovirt.org/27262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d43c8a2077e40b8b4314f02ea17bc3968c42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes