Nir Soffer has posted comments on this change.
Change subject: schedule: Introduce scheduling library ......................................................................
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/29607/15/tests/scheduleTests.py File tests/scheduleTests.py:
Line 135: min = clock.latency[0] Line 136: avg = sum(clock.latency) / len(clock.latency) Line 137: med = clock.latency[len(clock.latency) / 2] Line 138: max = clock.latency[-1] Line 139: print 'latency - avg: %.3f min: %.3f median: %.3f max: %.3f' % (
I didn't find any instructions which could tell me which version of python,
print is not about personal preferences - I'm using what available and idiomatic in Python 2.6, which is the version available on EL 6, our main platform. Line 140: avg, min, med, max) Line 141: # This may be too strict on overloaded machines. We may need to Line 142: # incrase this value if it breaks in the CI. On my laptop I get Line 143: # avg latency 1 millisecond.
Line 138: max = clock.latency[-1] Line 139: print 'latency - avg: %.3f min: %.3f median: %.3f max: %.3f' % ( Line 140: avg, min, med, max) Line 141: # This may be too strict on overloaded machines. We may need to Line 142: # incrase this value if it breaks in the CI. On my laptop I get
typo:incrase
Done Line 143: # avg latency 1 millisecond. Line 144: self.assertTrue(max < 0.1) Line 145: Line 146: