Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make validateStorageServerConnection API call a noop ......................................................................
Make validateStorageServerConnection API call a noop
This call is useless and slow. It check different things in different levels for different storage types and does not guarantee a future connect will succeed. Until someone actually defines what is actually being validated (params? hostname? permissions? authentication tokens?) I suggest to just disable this verb so it doesn't make any NFS connection take twice as long and be exponentially more complex.
Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b --- M vdsm/storage/hsm.py 1 file changed, 10 insertions(+), 14 deletions(-)
Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1097 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com