Dan Kenigsberg has posted comments on this change.
Change subject: BZ#813423: Adding ENGINENAME macro ......................................................................
Patch Set 1: Looks good to me, approved
ShaoHe Feng 5:53 PM but there are some command help infos and variables using "RHEVM". I wonder should we clean them ?
Yes, probably. But if they affect an existing Vdsm API, it should be done with care.
-- To view, visit http://gerrit.ovirt.org/3761 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Bruce Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming sming56@gmail.com