Nir Soffer has posted comments on this change.
Change subject: volume: support multi line metadata values
......................................................................
Patch Set 3:
Also, the need for storing multilines in the metadata file is not clear - the description
field is meant to hold one line description, not short stories or application meta data.
Storing multiline json data in the metadata file does not sound like a good idea.
If we like to store additional metadata, we probbaly should use custom keys:
For example:
SIZE = 1
FORMAT = COW
OVF_DATE = ...
OVF_SIZE = ...
And not:
SIZE = 1
FORMAT = COW
DESCRIPTION = {
"ovf-date": "...",
"ovf-size": "..."
}
--
To view, visit
http://gerrit.ovirt.org/28493
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No