Eduardo has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py:
Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception:
This change was introduced by I2ecf801d58b34c1c811e311e3779887a406af5f0 on
You are wrong.
Change-Id: I593060e354c0bdc9b19f4e11a376094d83e567ce
Anyway maintaining wrong behaviours is not "BC" . Line 212: # log any exception, but keep going Line 213: self.log.error("Error trying to check/update domain %s role", Line 214: sdUUID, exc_info=True) Line 215: