Dan Kenigsberg has posted comments on this change.
Change subject: getVolumeInfo() new implementation. ......................................................................
Patch Set 7:
(1 comment)
.................................................... File vdsm/storage/volume.py Line 894: else: Line 895: info = self.metadata2info(meta) Line 896: info["capacity"] = str(int(info["size"]) * BLOCK_SIZE) # Virtual Line 897: del info["size"] # Remove the virtual (by volMD) size [blocks] Line 898: if info['mtime'] == "" and self.__class__.__name__ == "FileVolume": This breaks for GlusterVolume that inherits from FileVolume. I'd rather you fix FileVolume.getVolumeMtime() instead of in-lining it, possibly raising NotImplemented in BlockVolume.getVolumeMtime(). Line 899: info['mtime'] = self.oop.os.stat(self.volumePath).st_mtime Line 900: # If image was set to illegal, mark the status same Line 901: # (because of VDC constraints) Line 902: if info['legality'] == ILLEGAL_VOL: