Dan Kenigsberg has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting. ......................................................................
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/26951/4/vdsm/caps.py File vdsm/caps.py:
Line 391: Line 392: Line 393: def _getSELinux(): Line 394: selinux = dict() Line 395: selinux['mode'] = str(utils.getSELinuxEnforceMode())
All the int values that are part of the response are converted to string:
right. let us conform.
However, have you considered reporting the strings enforcing/permissive/disabled ? I believe it would be easier to understand. Line 396: Line 397: return selinux Line 398: Line 399:
Line 393: def _getSELinux(): Line 394: selinux = dict() Line 395: selinux['mode'] = str(utils.getSELinuxEnforceMode()) Line 396: Line 397: return selinux
I think additional level is a good idea because it'd allows us to add more
good reason indeed. Line 398: Line 399: Line 400: def get(): Line 401: targetArch = getTargetArch()