Nir Soffer has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45823/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 1495: 'pathstatus': ['BlockDevicePathInfo'],
Line 1496: 'pathlist': ['IscsiSessionInfo'],
'logicalblocksize': 'uint',
Line 1497: 'physicalblocksize': 'uint', 'partitioned':
'bool',
Line 1498: 'pvsize': 'uint', 'status':
'BlockDeviceStatus',
Line 1499: 'vgname': 'str'}}
This is typically the sd uuid, but may be also another name, so I
don't pro
Here is an example:
1. I created a new vg on shared storage
2. Restart vdsm
3. This is vdsm lvm cache's vgs dict
(Extracted using manhole, see
https://gerrit.ovirt.org/32147)
>> lvm._lvminfo._vgs.keys()
['testy-test',
'6b8b0ab3-10d5-4b2e-984f-1a55ee6b1ceb',
'6c77adb1-74fc-4fa9-a0ac-3b5a4b789318']
4. Get devices list
(Using vdsClient -s 0 getDevicelist)
{'GUID': '36001405360bcafdd9d544c3bcc0debaf',
'capacity': '53687091200',
'devtype': 'iSCSI',
'fwrev': '4.0',
'logicalblocksize': '512',
'pathlist': [{'connection': '10.35.0.99',
'initiatorname': 'default',
'iqn': 'iqn.2003-01.org.dumbo.target1',
'port': '3260',
'portal': '1'}],
'pathstatus': [{'capacity': '53687091200',
'lun': '2',
'physdev': 'sdc',
'state': 'active',
'type': 'iSCSI'}],
'physicalblocksize': '512',
'productID': 'target1-02',
'pvUUID': '9VePZB-QnAI-n91j-lV4D-RId6-jxFR-y0Y1br',
'pvsize': '53678702592',
'serial': 'SLIO-ORG_target1-02_360bcafd-d9d5-44c3-bcc0-debaf72b305d',
'status': 'used',
'vendorID': 'LIO-ORG',
'vgUUID': 'YD7bvz-PrqO-m8Fa-5n5f-vQ77-H9IP-sS6M0J',
'vgname': 'testy-test'},
Note vgname: "testy-test" - does not look like a UUID to me :-)
Line 1500:
Line 1501: ##
Line 1502: # @Host.getDeviceList:
Line 1503: #
--
To view, visit
https://gerrit.ovirt.org/45823
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes