Change in vdsm[master]: Add deathSignal options to better peopen

Saggi Mizrahi has posted comments on this change.

Change subject: Add deathSignal options to better peopen
......................................................................

Patch Set 9: (1 inline comment)

....................................................
File vdsm/betterPopen/__init__.py
Line 36:     def __init__(self, args, close_fds=False, cwd=None, env=None,
Line 37:             # deathDignal is the signal that will be sent to the child process
Line 38:             # once the parent dies. This is not part of the standard python
Line 39:             # popen and when using standard peopen we should make sure we
Line 40:             # reimplement this.
No, it's a Linux specific API with a very odd semantic. I doubt it's going to get included upstream.
Line 41:             deathSignal=0):
Line 42:         if not isinstance(args, list):
Line 43:             args = list(args)
Line 44:

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server