Shahar Havivi has posted comments on this change.
Change subject: setVmTicket: add before and after hooks ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm_cli/vdsClient.py Line 311: params = {'userName': userName, 'userId': userId} yes, but me must check if it get 3 params since by now the forth param was optional...
Line 1625: ('<vmId> <password> <sec> [disconnect|keep|fail]', Done
.................................................... File vdsm/libvirtvm.py Line 1925: userName = params.get('userName', '') Done
-- To view, visit http://gerrit.ovirt.org/3565 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com