Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
......................................................................
Patch Set 3: Code-Review-1
Nir, guys,
I don't think we need to correct this old code. Instead, we shall replace it when the
time comes and not care about the checks here, they have become redundant.
getNicsVlanAndBondingForNetwork is only used in showNetwork and delNetwork to extract
information from netinfo.NetInfo, in not a trivial way I might add.
getBondingForNic appears in objectivizeNetwork and Bond._objectivizeSlaves.
The bottom line here is that if something was broken in network configuration we would
have already caught that when creating past networks.
--
To view, visit
http://gerrit.ovirt.org/34361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No