Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: better rollback
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
just a small nit on a function name. +1 otherwise.
https://gerrit.ovirt.org/#/c/46907/14/vdsm_hooks/ovs/ovs_before_network_setu...
File vdsm_hooks/ovs/ovs_before_network_setup.py:
Line 77: _destroy_ovs_net
maybe add 'libvirt' to the function name? (and log msg)
--
To view, visit
https://gerrit.ovirt.org/46907
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Ido Barkan
ibarkan@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
osvoboda@redhat.com
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes