Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes ......................................................................
Patch Set 7:
In master the implementation should be future maintainable not backward portable as suggested.
I think that backward portability is not less important than future maintainability.
This means that if the entire logic can be closed in shell at pre-start in a simple manner, add this to pre-start and not vdsm-tool.
I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain.
I would like to have one file with the deactivation logic, that I can test separately from the context where it is used, and use the same file in both upstream and downstream.
How about installing this Python script where vdsm_init_common.sh is, and invoking it from pre-start task function in upstream, and from vdsmd.init in downstream?