Igor Lvovsky has posted comments on this change.
Change subject: BZ#744704 - Add rollback support for complex tasks
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File vdsm/storage/task.py
Line 1053: raise TypeError("recovery param %s(%s) must be Recovery
object" % (repr(recovery), type(recovery)))
Line 1054: if not recovery.name:
Line 1055: raise ValueError("replaceRecoveries: name is required")
Line 1056: recovery.setOwnerTask(self)
Line 1057: rec = stubRecoveryObj
How rec=[] will help me? I need to compare rollback's name to SENTINEL_ROLLBACK.
Line 1058: try:
Line 1059: while (rec.name != SENTINEL_ROLLBACK):
Line 1060: rec = self.popRecovery()
Line 1061: rec = self.recoveries
Line 1056: recovery.setOwnerTask(self)
Line 1057: rec = stubRecoveryObj
Line 1058: try:
Line 1059: while (rec.name != SENTINEL_ROLLBACK):
Line 1060: rec = self.popRecovery()
It used as 'while' condition
Line 1061: rec = self.recoveries
Line 1062: except Exception:
Line 1063: rec = []
Line 1064: rec.append(recovery)
Line 1060: rec = self.popRecovery()
Line 1061: rec = self.recoveries
Line 1062: except Exception:
Line 1063: rec = []
Line 1064: rec.append(recovery)
I don't see any mess here, but if it bothering you I can fix this part
Line 1065: self.recoveries = rec
Line 1066: self.persist()
Line 1067:
Line 1068:
--
To view, visit
http://gerrit.usersys.redhat.com/1041
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie36ac02475f3f6438a63fbcbd26730862216cebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>