Francesco Romani has posted comments on this change.
Change subject: execCmd: no need to pass the default sudo=False value
......................................................................
Patch Set 2: Code-Review+1
Looks OK. Not 100% confident about the storage, which I know less, but AFAIK is ok. Moreover, jenkins failures seem unrelated.
--
To view, visit
http://gerrit.ovirt.org/24145
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra
vfeenstr@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No