Assaf Muller has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27262/1/vdsm/network/sourceroute.py
File vdsm/network/sourceroute.py:
Line 110: rmFile(DynamicSourceRoute.getTrackingFilePath(device))
Line 111:
Line 112: @staticmethod
Line 113: def _getRoutes(table, device):
Line 114: routes = []
If a host has hundreds of VLAN devices it would be a shame to iterate through all routes
instead of just a specific table. I did not fully understand the issue from the commit
message (Dan already touched this), but wouldn't it be possible to continue getting
the routes from a specific table, but deal with local routes later on?
Line 115: for entry in routeShowTable('all'):
Line 116: try:
Line 117: route = Route.fromText(entry)
Line 118: except ValueError:
--
To view, visit
http://gerrit.ovirt.org/27262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d43c8a2077e40b8b4314f02ea17bc3968c42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes