Ala Hino has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command ......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:
Line 86: if format: Line 87: cmd.extend(("-f", format)) Line 88: Line 89: cmd.append(image) Line 90: out = _run_cmd(cmd, raw=True)
raw=True is not needed, it enforced by _run_cmd.
Done Line 91: Line 92: try: Line 93: qemu_info = _parse_qemuimg_json(out) Line 94: except ValueError:
Line 148: if format: Line 149: cmd.extend(("-f", format)) Line 150: Line 151: cmd.append(image) Line 152: out = _run_cmd(cmd, raw=True)
raw=True is not needed, it enforced by _run_cmd.
Done Line 153: Line 154: try: Line 155: qemu_check = _parse_qemuimg_json(out) Line 156: except ValueError:
Line 360: Line 361: def _run_cmd(cmd, cwd=None): Line 362: rc, out, err = commands.execCmd(cmd, raw=True, cwd=cwd) Line 363: if rc != 0: Line 364: raise QImgError(rc, out, err)
cmd missing
Done