Eduardo has posted comments on this change.
Change subject: Set exc_info=True when self.message is used in log.error for vds_bootstrap ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 632: logging.error(self.message, exc_info=True) A lot of more useful info can be returned here. Rewrite this function, fReturn = False can't raise.
-- To view, visit http://gerrit.ovirt.org/945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id5fa63d9809e5f7130e304eceede6d41a27a12a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com