Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44061/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 322: if drive.get('diskType') == DISK_TYPE.NETWORK:
Line 323: volinfo = drive.get('volumeInfo')
Line 324: volPath = volinfo['path']
Line 325: drive['protocol'] = volinfo['protocol']
Line 326: if drive.get('hosts') is None:
In ceph we get hosts from caller (engine) while in glster, caller
doesn't p
But ceph disk do not reach this branch, since they are not in PDIV
format.
Ceph disks are handled in the "elif "path" in drive branch (line 366).
Line 327: hosts = [dict(name=volinfo['hosts'][0],
Line 328: port=volinfo['port'],
Line 329: transport=volinfo['transport'])]
Line 330: drive['hosts'] = hosts
--
To view, visit
https://gerrit.ovirt.org/44061
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes