Dan Kenigsberg has submitted this change and it was merged.
Change subject: Cleanup of storage domain creation in hsm.py
......................................................................
Cleanup of storage domain creation in hsm.py
This patch changes the specific per domain type creation handling is done
to remove duplicate code, allow uniform error handling when we call the
actual creation and make the flow more clear
Change-Id: Ib4f3771e40595d77fd80811c6b7ea6bf4c768d69
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/45375
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Verified
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/45375
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f3771e40595d77fd80811c6b7ea6bf4c768d69
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org