Hans De Goede has posted comments on this change.
Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 864: doc = xml.dom.minidom.Document() Done
Line 866: ['index', 'model', 'master', 'address']) master may be necessary to be able to set a different startport then the default if we ever want to do that, address will get assigned automatically by libvirt the first time the vm is created, but AFAIK after the first time ovirt will store the given address and specify it the next time so that hardware does not move around when a vm gets re-created later. Note that specifying of either is optional, if you don't specify any of these they simply won't be used.
-- To view, visit http://gerrit.ovirt.org/4095 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com