Nir Soffer has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
......................................................................
Patch Set 16: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc
File contrib/jsonrpc:
Line 43: ...
Line 44:
Line 45: where file content is:
Line 46: storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2,
Line 47: storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
thanks for this example, but what about the quite-important VM.create
comma
The original version of this client was reading plain json from the file. This
is the only way to express complex structures.
The simple key=value format is useful only for command line argument, where it is less
verbose than writing actual json in the command line.
See
https://gerrit.ovirt.org/#/c/35181/5/contrib/jsonrpc,unified
I asked Piotr to maintain these semantics, and change only the jsonrpc infrastructure to
use our client instead of stomp.
Line 48:
Line 49: It is also possible to read parameters from standard input, creating complex
Line 50: parameters interactively:
Line 51:
--
To view, visit
https://gerrit.ovirt.org/35181
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes