Federico Simoncelli has posted comments on this change.
Change subject: vm: pre-validate disks for snapshot ......................................................................
Patch Set 6: Verified+1
(1 comment)
Verified (with http://gerrit.ovirt.org/24867 ): successful live snapshot and failed prepareVolumePath (rollback).
http://gerrit.ovirt.org/#/c/20029/6/vdsm/vm.py File vdsm/vm.py:
Line 3966: return errCode['snapshotErr'] Line 3967: Line 3968: if vmDrive.hasVolumeLeases: Line 3969: return errCode['noimpl'] Line 3970: Transient disk check has been split to:
http://gerrit.ovirt.org/24867 Line 3971: vmDevName = vmDrive.name Line 3972: Line 3973: newDrives[vmDevName] = tgetDrv.copy() Line 3974: newDrives[vmDevName]["poolID"] = vmDrive.poolID