Change in vdsm[master]: BZ#802759 - Make old FD shutdown a bit more robust

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#802759 - Make old FD shutdown a bit more robust
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

my request regarding a fatter commit message still applies.

....................................................
File vdsm/storage/processPool.py
Line 280:                         if e in (errno.EINTR, errno.EAGAIN):
actually, this has to be e.errno.

close(2) does not mention EAGAIN.

btw, imho it would be clearer to have

def repeatUntilNoSignal(func, args=[], kwargs={}):
    while True:
        try:
           return func(args, kwargs)
        except OSError as e....

and call repeatUntilNoSignal(os.close).

--
To view, visit http://gerrit.ovirt.org/2844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117072cd5e25cb4e618a85ca9990451c03095de0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg