Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162: finally:
Line 163: if self.autodelete:
Line 164: self._autodelete()
Line 165:
Line 166: def _may_run(self):
Add docstrings for each of these helpers.
Line 167: with self._status_lock:
Line 168: if self.status == STATUS.ABORTED:
Line 169: logging.debug('Refusing to run aborted job %r',
self._id)
Line 170: return False
--
To view, visit
https://gerrit.ovirt.org/65102
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes