Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/27548/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 652: or
s/or/of
Line 659: arg = arg.replace("'", "'")
Line 660: if ' ' in arg:
Line 661: arg = "'" + arg + "'"
Line 662: parts.append(arg)
Line 663: return ' '.join(parts)
did you compare the cpu usage with this implementation ?
Line 664:
Line 665:
Line 666: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True,
Line 667: printable=None, env=None, sync=True, nice=None, ioclass=None,
--
To view, visit
http://gerrit.ovirt.org/27548
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Alon Bar-Lev
alonbl@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes