Assaf Muller has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes
......................................................................
Patch Set 2:
You might have individuals placing /32 bit addresses on non-VM networks. For example,
10.0.0.1/32 on one interface, and 10.0.0.2/32 on another. Taking the first 31 bits you
wouldn't be able to differentiate between them. I'd look into the routes table
file instead - It would solve IPv6 as well, which the current solution does not.
--
To view, visit
http://gerrit.ovirt.org/27262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d43c8a2077e40b8b4314f02ea17bc3968c42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No