Change in vdsm[master]: hook: before_network_rollback, after_network_rollback

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hook: before_network_rollback, after_network_rollback
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45085/4/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:

Line 59:                           'network.', exc_info=(type, value, traceback))
Line 60:         else:
Line 61:             hooks.before_network_rollback()
Line 62:             leftover = self.rollback()
Line 63:             hooks.after_network_rollback()
I believe that a cleaner hookpoint is after_network_setup_failure.

BTW, in your suggested context, I think you should raiseError within
after_network_rollback, since you need to raise RollbackIncomplete.
Line 64:             if leftover:
Line 65:                 raise RollbackIncomplete(leftover, type, value)
Line 66: 
Line 67:     def rollback(self):


-- 
To view, visit https://gerrit.ovirt.org/45085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes