Change in vdsm[master]: vm: new parameter 'protected' for vm creation

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: vm: new parameter 'protected' for vm creation
......................................................................

Patch Set 4:

(1 comment)

....................................................
File vdsm/vm.py
Line 1645:         """
Line 1646:         self._dom = None
Line 1647:         self.conf = {
Line 1648:             'pid': '0',
Line 1649:             'protected': config.getboolean('irs', 'use_volume_leases'),
Yes it's per VM, but the default value is taken from the configuration (default: false), which means that you can override the default and set it to true for all the VMs.

If you look at the next line (1650) we update this value with the parameters coming from the engine.

Bottom line: if engine provides a value for "protected" we use such value, if it's missing then we use the default provided by 'use_volume_leases'.
Line 1650:         }
Line 1651:         self.conf.update(params)
Line 1652:         self.cif = cif
Line 1653:         self.log = SimpleLogAdapter(self.log, {"vmId": self.conf['vmId']})