Zhou Zheng Sheng has posted comments on this change.
Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/sampling.py Line 160: for p in self.MONITORED_PATHS: Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', '--format=%T', Line 162: p]) Line 163: if rc == 0 and out[0] == 'tmpfs': Line 164: continue I think this piece of code can be put in __init__():
self.MONITORED_PATHS = filter( lambda p: utils.execCmd( ['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], []), self.MONITORED_PATHS)
or
self.MONITORED_PATHS = [ p for p in MONITORED_PATHS if utils.execCmd( ['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], [])]
Then _getDiskStats() does not have to stat the file system every time. Line 165: Line 166: free = 0 Line 167: try: Line 168: stat = os.statvfs(p)