Deepak C Shetty has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume ......................................................................
Patch Set 5:
(1 comment)
Another option could be do a readonly mount in a hidden dir and do 'df -h' whenever u need the latest stats. thats possible too... I know its not perfect tho!
.................................................... File vdsm.spec.in Line 1271: %dir %{_datadir}/%{vdsm_name}/gluster Line 1272: %doc COPYING Line 1273: %{_datadir}/%{vdsm_name}/gluster/api.py* Line 1274: %{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json Line 1275: %{_datadir}/%{vdsm_name}/gluster/gfapi.py* I will suggest then not to use the name as gfapi.py, since thats misleading and wrong. Maybe say statvfs.py or have gluster/gfapi/stavfs.py .. that looks more logical considering that u don't plan to support everything via gfapi.
Any reason why u r putting this in vdsm-gluster pkg and not in -api pkg ? Since gfapi.py needs libgfapi.so.XX it should be part of -api pkg, in which case, the vdsm pkg itself can make use of it in future as needed. Line 1276: %{_datadir}/%{vdsm_name}/gluster/hooks.py* Line 1277: %{_datadir}/%{vdsm_name}/gluster/services.py* Line 1278: %endif Line 1279: