Yaniv Bronhaim has posted comments on this change.
Change subject: Remove unnecesary preparePaths.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/clientIF.py
Line 981
Line 982
Line 983
Line 984
Line 985
I don't agree here:
1. We do that
2. We do that
3. I don't understand why we need to reconnect? We are already connected if vms are
still running..
4. Same as 3
5. Same as 3 - why to keep something that maybe in the future we will need... Until the
future we want to do it faster and righter.. no?
6. We could resume the vm stats after 2...
Federico, Please explain why you think we need real storage operations here because I
don't understand..
--
To view, visit
http://gerrit.ovirt.org/786
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35890d36227633ca147387d670c152b9be357e50
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server