Dan Kenigsberg has posted comments on this change.
Change subject: get max_tasks and thread_pool_size from config by getint() ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/9035/4//COMMIT_MSG Commit Message:
Line 14: So int is more reasonable than float Line 15: Line 16: Additionally, create a new configuration variable Line 17: mailbox_thread_pool_size so the number of threads assigned to the Line 18: storage mailbox can be set independently.
It was requested by Ayal. Rather then make the storage_mailbox threadpool
I am sure that Ayal had good reasons, and maybe an actual case where it is important to tweak this value. However, they are not clear to me. I'd rather have the constant "5" hard-coded than introduce a configurable that almost no one understands and (hopefully) no one uses.
Adam, would you please split it off this patch?
Nir, could you shed more light on this? Line 19: Line 20: Change-Id: I9fc719b1b4238b0df2d9c882777cb75d7a27d4df Line 21: Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com