Mark Wu has posted comments on this change.
Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I agree with that the using udev is better than grub conf. Just a minor suggestion inline.
.................................................... File vdsm/storage/12-vdsm-elevator.rules Line 8: # Line 9: Line 10: # Udev rules for elevator setting. Line 11: Line 12: ACTION=="add|change", SUBSYSTEM=="block", ENV{DEVTYPE}=="disk", RUN+="vdsm-elevator.sh deadline" I think we can just use a command line instead of adding new script, like: RUN+="/bin/sh -c 'echo deadline > /sys$DEVPATH/queue/scheduler'"
For dm devices, we can filter out them by udev key word or just write it unconditionally.
-- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Fabian Deutsch fabiand@fedoraproject.org Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com