Nir Soffer has posted comments on this change.
Change subject: Added standard build skeleton ......................................................................
Patch Set 3:
(5 comments)
Nice!
https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.sh File automation/check-patch.sh:
Line 1: #!/bin/bash -e Line 2: # Line 3: # Run on each patch to gerrit, should be faster than check-meged and require Line 4: # less resources but thorough enough to provide relevant feedback David: we need more specific contract with the ci
- how do you signal success? - how do you signal failure? - how do you signla error?
I think the simplest way would be to use the process return value:
- 0 - success: +1 patch - 1 - some tests failed: -1 patch - 2 - error: no change in patch Line 5: Line 6: echo "Hello - ifra functional tests" Line 7: Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*
Line 4: # less resources but thorough enough to provide relevant feedback Line 5: Line 6: echo "Hello - ifra functional tests" Line 7: Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.* You do everything here except running the tests, which is the only thing we should do here :-) Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm* Line 10: Line 11: Line 12: vdsm-tool configure --force
Line 5: Line 6: echo "Hello - ifra functional tests" Line 7: Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.* Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm* Errors are ignored - we should check and handle error for each command. Line 10: Line 11: Line 12: vdsm-tool configure --force Line 13: service vdsmd start
Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm* Line 10: Line 11: Line 12: vdsm-tool configure --force Line 13: service vdsmd start Why do we need to buid, create rpms, install, configure and start vdsm for each version in each patch?
This is waste of resources. I think we should only run the tests (make check) for each patch, do the rest during merge. Line 14: Line 15: Line 16: # copy logs Line 17: mkdir exported-artifacts
Line 14: Line 15: Line 16: # copy logs Line 17: mkdir exported-artifacts Line 18: cp /var/log/vdsm/* exported-artifacts Failure here must not fail the patch in gerrit