Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID. ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 10: Consider removing this function. If not, rename it. what is 'this' function? why remove? rename to what?
.................................................... File vdsm/storage/hsm.py Line 209: sdDom = sdCache.produce(sdUUID=sdUUID) sdDom = storage domain domain? what's wrong with dom?
-- To view, visit http://gerrit.ovirt.org/3465 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com