Ayal Baron has posted comments on this change.
Change subject: Fix fix fix getDomUuidFromVolumePath() ......................................................................
Patch Set 1:
(1 comment)
.................................................... File vdsm/storage/fileVolume.py Line 43: Line 44: def getDomUuidFromVolumePath(volPath): Line 45: # fileVolume path has pattern: Line 46: # */sdUUID/images/imgUUID/volUUID Line 47: return volPath.split('/')[-4] previously the method assumed that the /rhev/dc/ part is constant and that broke. Now it assumes that /images/imgUUID/volUUID is constant and this is also not guaranteed. The problem here is that we're trying to infer things from the path while the calling functions probably already have this info available. i.e. proper solution would likely be to just get rid of this method. Line 48: Line 49: Line 50: class FileVolume(volume.Volume): Line 51: """ Actually represents a single volume (i.e. part of virtual disk).