From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: configfile: remove old configuration when attribute is set
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/74331/3/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/configfile.py:
Line 170: key = line.split("=")[0]
Line 171: if key not in self._entries:
Line 172: f.write(fullline)
Line 173: if self._entries:
Line 174: self._writeEntries(f)
Nir suggest to comment out the line instead of removing it. with a comment "removed
by vdsm"
Line 175:
Line 176: os.rename(tname, self._filename)
Line 177:
Line 178: if self._oldmod != os.stat(self._filename).st_mode:
--
To view, visit
https://gerrit.ovirt.org/74331
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1dba75449b712432e0c2bc5b128cc996ede0153
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes