Dan Kenigsberg has posted comments on this change.
Change subject: register: Add --persist-uuid ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44431/1/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py:
Line 275: f.write(self.uuid) Line 276: Line 277: if utils.isOvirtNode(): Line 278: from ovirt.node.utils.fs import Config Line 279: Config().persist(__VDSM_ID) we persist the uuid anyway, so the name of the new argument is misleading.
--persist-uuid should mean "I would like to write VDSM_ID onto the filesystem".
in this patch you are adding something like
--vdsm-uuid - override the default vdsm uuid. this may be useful if dmidecode returns an unconfigured host id. Line 280: Line 281: self.logger.info("Host UUID: {u}".format(u=self.uuid)) Line 282: Line 283: def download_ca(self):