1:51 p.m.
Eduardo has uploaded a new change for review.
Change subject: Related to BZ# - One shot prepare.
......................................................................
Related to BZ# - One shot prepare.
The number of storage accesses is reduced to 1 or none instead of
the recursive volume images produces.
Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/4220/1
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
2:29 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 16:
(1 comment)
....................................................
Commit Message
Line 9: The number of storage accesses is reduced to 1 or none instead of
Line 10: the recursive volume images produces.
Line 11: Requires a new selinux policy.
Line 12:
Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960952
Also: 999840
Line 14: Related to BZ#769502, BZ#990509.
Line 15:
Line 16: Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3:27 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4319/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3422/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4238/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:17 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: One shot prepare.
......................................................................
One shot prepare.
The number of storage accesses is reduced to 1 or none instead of
the recursive volume images produces.
Requires a new selinux policy.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960952
Related to BZ#769502, BZ#990509.
Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/4220
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
M vdsm.spec.in
M vdsm/clientIF.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/imageRepository/formatConverter.py
M vdsm/storage/sd.py
9 files changed, 111 insertions(+), 61 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:17 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 17: Verified+1 Code-Review+2
Patch http://gerrit.ovirt.org/17714/ should have been merged only on top of this one, as
this is the only combination that was verified by QE.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:03 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 16: Verified+1
Verified by Sandro and Elad in previous version without significant differencies.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:31 p.m.
New subject: Change in vdsm[master]: One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:41 p.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4269/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3372/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4188/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:19 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 15:
(2 comments)
....................................................
Commit Message
Line 9: The number of storage accesses is reduced to 1 or none instead of
Line 10: the recursive volume images produces.
Line 11: Requires a new selinux policy.
Line 12:
Line 13: Related to BZ#960952, BZ#769502, BZ#990509.
this solves bug 960952. not related to
Line 14:
Line 15: Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
....................................................
File vdsm/storage/fileSD.py
Line 423: Creates a compatiblity layer for vdsm and qemu-img use.
Line 424:
Line 425: srcImgPath: Dir where the image volumes are.
Line 426: """
Line 427: sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)
/var/run/vdsm hard coded here?
Line 428: fileUtils.createdir(sdRunDir)
Line 429: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 430: try:
Line 431: os.symlink(srcImgPath, imgRunDir)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:42 p.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4247/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3352/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4168/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:34 p.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 14: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4246/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3351/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4167/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:32 p.m.
New subject: Change in vdsm[master]: One shot prepare.
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 14:
The getVSize() unit test failure will be fixed by rebasing on top of an updated master.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:24 p.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 13: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4245/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3350/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4166/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:23 p.m.
New subject: Change in vdsm[master]: One shot prepare.
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 13:
The getVSize() unit test failure will be fixed by rebasing on top of an updated master.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:02 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 12: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4198/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3303/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4119/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:46 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 11:
(2 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1027: def getAllRemnants(self):
Line 1028: vols, rems = self.getAllVolumesImages()
Line 1029: return rems
Line 1030:
Line 1031: def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
s/linkRunImage/createImageLinks/
Line 1032: """
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1029: return rems
Line 1030:
Line 1031: def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
Line 1032: """
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
s/.*/qcow chain is build by reading each qcow header and reading the path to the parent.
When creating the qcow layer, we pass a relative path which allows us to build a directory
with links to all volumes in the chain anywhere we want. This method creates a directory
with the image uuid under /var/run/vdsm and creates sym links to all the volumes in the
chain/
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:43 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 11:
Addressing the required changes for next patches.
More changes, like replace the path by a constant will be posted later.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:17 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 11: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4089/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3194/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4010/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:03 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
First, need to fix comments I'm giving -2 since without fixing
selinux issue this must not be introduced (as it will break run vm). once selinux changes
are introduced then we can introduce this patch (after fixes)
Selinux issue fixed on F19:
https://admin.fedoraproject.org/updates/FEDORA-2013-15088/selinux-policy-...
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:32 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 257:
Line 258: volPath = res['path']
Line 259: # drive['volsInfo'] is unsorted!
Line 260: drive['volumeInfo'] = res['imgVolumesInfo']
Line 261: drive['volumeInfo'] = res['info']
Don't forget to fix all the volumeChain uses in vm.py (and other files if any)
Line 262:
Line 263: # GUID drive format
Line 264: elif "GUID" in drive:
Line 265: visible =
self.irs.scanDevicesVisibility([drive["GUID"]])
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3:04 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(2 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
I'm sure Dan won't mind if we use the "Path definitions" section in
constants.py.in.
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
Line 1061: If the image is based on a template image it will be activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
For this you could just provide a getDomainDevPath method in this class.
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
Line 1068: def getVolumeLease(self, imgUUID, volUUID):
Line 1069: """
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:16 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Yaniv Bronhaim has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(1 comment)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
at least use P_VDSM_RUN
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:45 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 257:
Line 258: volPath = res['path']
Line 259: # drive['volsInfo'] is unsorted!
Line 260: drive['volumeInfo'] = res['imgVolumesInfo']
Line 261: drive['volumeInfo'] = res['info']
This must be addressed ASAP as it's preventing (all) the leases to be passed to the
vm.
Line 262:
Line 263: # GUID drive format
Line 264: elif "GUID" in drive:
Line 265: visible =
self.irs.scanDevicesVisibility([drive["GUID"]])
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:52 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10: Code-Review-1
(6 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
This should be a constant.
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
Line 1061: If the image is based on a template image it will be activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
os.path.join("/dev", ...
is already appearing so many times in this file that it makes me think that we need to
encapsulate it.
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
Line 1068: def getVolumeLease(self, imgUUID, volUUID):
Line 1069: """
....................................................
File vdsm/storage/fileSD.py
Line 423: Creates a compatiblity layer for vdsm and qemu-img use.
Line 424:
Line 425: srcImgPath: Dir where the image volumes are.
Line 426: """
Line 427: sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)
This should be a constant.
Line 428: fileUtils.createdir(sdRunDir)
Line 429: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 430: try:
Line 431: os.symlink(srcImgPath, imgRunDir)
Line 430: try:
Line 431: os.symlink(srcImgPath, imgRunDir)
Line 432: except OSError as e:
Line 433: if e.errno == errno.EEXIST:
Line 434: self.log.debug("img run dir already exists: %s",
imgRunDir)
This implicitly assumes that the same storage domain cannot be accessed using different
nfs hosts (you could use vdsm.utils.forceLink).
Line 435: else:
Line 436: self.log.error("Failed to create img run dir: %s",
imgRunDir)
Line 437: raise
Line 438:
Line 435: else:
Line 436: self.log.error("Failed to create img run dir: %s",
imgRunDir)
Line 437: raise
Line 438:
Line 439: return imgRunDir
I see some code/logic duplication here in linkRunImage (same as blockSD). Maybe we can
extract it in some common method/function.
Line 440:
Line 441: def activateVolumes(self, imgUUID, allVols):
Line 442: """
Line 443: Activate all the volumes listed in volUUIDs
Line 446: # set. We have to set it here if we want qemu-kvm to write to old
Line 447: # NFS volumes. In theory it is necessary to fix the permission
Line 448: # of the leaf only but to not introduce an additional requirement
Line 449: # (ordered volUUIDs) we fix them all.
Line 450: imgDir = os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES,
Another solution to the "stale" symlinks would be using the
/rhev/<spuuid>/<sduuid> path here instead of self.mountpoint/<sduuid>.
Line 451: imgUUID)
Line 452: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 453: volPaths = tuple(os.path.join(imgDir, v) for v in volUUIDs)
Line 454: for volPath in volPaths:
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:16 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
Any chance to have this patch queue merged soon?
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:47 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Yaniv Bronhaim has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2725:
Line 2726: leafPath = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID,
Line 2727: leafUUID)
Line 2728: for volUUID in imgVolumes:
Line 2729: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID,
volUUID)
Please use path prefix for reuse and add another patch set. This fix is necessary to
reduce initialization time
Line 2730: volInfo = {'domainID': sdUUID, 'imageID': imgUUID,
Line 2731: 'volumeID': volUUID, 'path': path}
Line 2732:
Line 2733: leasePath, leaseOffset = dom.getVolumeLease(imgUUID, volUUID)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:01 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:49 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2767/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3574/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3658/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:57 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2759/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3566/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3650/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:46 a.m.
New subject: Change in vdsm[master]: One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2748/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3555/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3639/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:39 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/128/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:37 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/128/
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:59 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10: Code-Review-2
(9 comments)
First, need to fix comments
I'm giving -2 since without fixing selinux issue this must not be introduced (as it
will break run vm).
once selinux changes are introduced then we can introduce this patch (after fixes)
....................................................
File vdsm/clientIF.py
Line 257:
Line 258: volPath = res['path']
Line 259: # drive['volsInfo'] is unsorted!
Line 260: drive['volumeInfo'] = res['imgVolumesInfo']
Line 261: drive['volumeInfo'] = res['info']
this looks like a bug to me.
Line 262:
Line 263: # GUID drive format
Line 264: elif "GUID" in drive:
Line 265: visible =
self.irs.scanDevicesVisibility([drive["GUID"]])
....................................................
File vdsm/storage/blockSD.py
Line 1027: def getAllRemnants(self):
Line 1028: vols, rems = self.getAllVolumesImages()
Line 1029: return rems
Line 1030:
Line 1031: def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
I don't understand the name of this method
Line 1032: """
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1029: return rems
Line 1030:
Line 1031: def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
Line 1032: """
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
?
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
Line 1059: allVols: getAllVolumes result.
Line 1060:
Line 1061: If the image is based on a template image it will be activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
you're already passing imgVols, not allVols, no need to call getVolsOfImage
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
....................................................
File vdsm/storage/fileSD.py
Line 417: volumes[volUUID] = {'imgs': [imgUUID], 'parent':
None}
Line 418: return dict((k, sd.ImgsPar(tuple(v['imgs']),
v['parent']))
Line 419: for k, v in volumes.iteritems())
Line 420:
Line 421: def linkRunImage(self, srcImgPath, imgUUID):
same
Line 422: """
Line 423: Creates a compatiblity layer for vdsm and qemu-img use.
Line 424:
Line 425: srcImgPath: Dir where the image volumes are.
Line 419: for k, v in volumes.iteritems())
Line 420:
Line 421: def linkRunImage(self, srcImgPath, imgUUID):
Line 422: """
Line 423: Creates a compatiblity layer for vdsm and qemu-img use.
ditto
Line 424:
Line 425: srcImgPath: Dir where the image volumes are.
Line 426: """
Line 427: sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)
Line 437: raise
Line 438:
Line 439: return imgRunDir
Line 440:
Line 441: def activateVolumes(self, imgUUID, allVols):
you're only ever passing imgVolumes, not allVols
Line 442: """
Line 443: Activate all the volumes listed in volUUIDs
Line 444: """
Line 445: # Volumes leaves created in 2.2 did not have group writeable bit
Line 448: # of the leaf only but to not introduce an additional requirement
Line 449: # (ordered volUUIDs) we fix them all.
Line 450: imgDir = os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES,
Line 451: imgUUID)
Line 452: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
you're already passing image volumes, why call this again?
Line 453: volPaths = tuple(os.path.join(imgDir, v) for v in volUUIDs)
Line 454: for volPath in volPaths:
Line 455: self.oop.fileUtils.copyUserModeToGroup(volPath)
Line 456:
....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 272: except (OSError, se.CannotActivateLogicalVolumes):
Line 273: log.error("Image %s can't be activated.",
Line 274: imgUUID, exc_info=True)
Line 275:
Line 276: for vol in sd.getVolsOfImage(allVolumes, imgUUID):
you're already calling getVolsOfImage here, do it separately before activateVolumes
and pass that
Line 277: try:
Line 278: v3ResetMetaVolSize(vol) # BZ#811880
Line 279: except qemuImg.QImgError:
Line 280: log.error("It is not possible to read the volume %s
"
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
12:50 p.m.
New subject: Change in vdsm[master]: One shot prepare.
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(3 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
I totally agree with you. But danken was unable to determine the optimal place for this
constant.
He asked to be merged in this form until a rework in progress on the constants will be
done, not by our team.
I presume that we need to wait until he will be back online.
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
Line 1061: If the image is based on a template image it will be activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
I agree.
Same as above.
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
Line 1068: def getVolumeLease(self, imgUUID, volUUID):
Line 1069: """
....................................................
File vdsm/storage/fileSD.py
Line 446: # set. We have to set it here if we want qemu-kvm to write to old
Line 447: # NFS volumes. In theory it is necessary to fix the permission
Line 448: # of the leaf only but to not introduce an additional requirement
Line 449: # (ordered volUUIDs) we fix them all.
Line 450: imgDir = os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES,
We need to be totally independent from SP.
Line 451: imgUUID)
Line 452: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 453: volPaths = tuple(os.path.join(imgDir, v) for v in volUUIDs)
Line 454: for volPath in volPaths:
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:23 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
selinux policy was released.
still need to address the remaining comments
....................................................
File vdsm/clientIF.py
Line 255: if res['status']['code']:
Line 256: raise vm.VolumeError(drive)
Line 257:
Line 258: volPath = res['path']
Line 259: # res['imgVolumesInfo'] is in arbitary order
s/is in arbitary/order of imgVokumesInfo is not guaranteed/
Line 260: drive['volumeChain'] = res['imgVolumesInfo']
Line 261: drive['volumeInfo'] = res['info']
Line 262:
Line 263: # GUID drive format
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:50 a.m.
New subject: Change in vdsm[master]: One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
Eduardo, let's solve the constants.py issue, as well as the unit test failure. This
patch is too important to be held on such trivialities.
Traceback (most recent call last):
File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/tests/volumeTests.py",
line 68, in test
self.volUUID)
File
"/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/storage/fileVolume.py",
line 409, in getVSize
volPath = os.path.join(sdobj.mountpoint, sdobj.sdUUID, 'images',
AttributeError: 'FileDomainMockObject' object has no attribute
'mountpoint'
....................................................
File vdsm/storage/blockSD.py
Line 1038: the chain.
Line 1039:
Line 1040: srcImgPath: Dir where the image volumes are.
Line 1041: """
Line 1042: sdRunDir = os.path.join("/var/run/vdsm/storage",
self.sdUUID)
It may not be the best idea to strengthen the dependency of the storage subsystem on vdsm
proper, but lacking any other idea, I suggest to put in lib/vdsm/constants.py.in
P_VDSM_STORAGE = P_VDSM_RUN + 'storage/'
and to use it both here and in fileSD.py.
Line 1043: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1044: fileUtils.createdir(imgRunDir)
Line 1045: for volUUID in volUUIDs:
Line 1046: srcVol = os.path.join(srcImgPath, volUUID)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:09 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: I would prefer that you didn't submit this
Let's discuss how to solve this: http://gerrit.ovirt.org/#/c/5521/
(Temporarily marking as -1 until we figure out what to do)
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:47 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4:38 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Federico Simoncelli has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2729: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID,
volUUID)
This looks like duplication of logic (and code): it introduces a new computation of the
volume path instead of reusing the one that we already have.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4:14 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:49 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
Please verify by starting a VM with a long chain and a preview snapshot.
Please get Federico's approval, too.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4:25 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 2723: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).iterkeys()
afair, imgVolumes[1:] are not sorted in any way. this means that chain[-1]['path']
is not proved to be path to the leaf.
Come to think of it, if you have a snapshot on the image, you cannot even tell who is the
image - and you must keep (and use!) volUUID in the arg list.
Line 2727: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID,
volUUID)
oh, and please keep new code in shorter lines.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:21 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2705: def prepareImage(self, sdUUID, spUUID, imgUUID, volUUID=None):
repeat: this change has to be documented.
Why can't you change the interface? Did it ever have any user out of vdsm?
In any case, the only in-vdsm user can, and should, be fixed.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
11:38 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Eduardo has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2705: def prepareImage(self, sdUUID, spUUID, imgUUID, volUUID=None):
Yes. You are preparing the whole image here. Was the same before.
The volUUID was planned for preparing only one volume. This is iiunused because there is a
prepareVolume interface.
Can't change the interface.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:28 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2705: def prepareImage(self, sdUUID, spUUID, imgUUID, volUUID=None):
the new implementation ignores the provided volUUID.
is this intentional? if so, this change of sematics *has* to be documented and explained.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:38 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
minor variable-naming issue
....................................................
File vdsm/storage/hsm.py
Line 2726: for vol in imgVolumes:
s/vol/volUUID/
you usually care for this differentiation.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12:10 a.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Eduardo has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2724: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, vol)
You are right. Was not submitted yet because implies rebasing the previous series.
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:12 p.m.
New subject: Change in vdsm[master]: Related to BZ#769502 - One shot prepare.
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#769502 - One shot prepare.
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Acking, but please look at inline comment
....................................................
File vdsm/storage/hsm.py
Line 2724: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, vol)
shouldn't this be in a separate function?
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3882
days inactive
4371
days old
vdsm-patches@lists.fedorahosted.org
47 comments
7 participants
participants (7)
-
abaron＠redhat.com -
Dan Kenigsberg -
ewarszaw＠redhat.com -
Federico Simoncelli -
Jenkins CI RO -
Sandro Bonazzola -
ybronhei＠redhat.com