Change in vdsm[master]: Renamed backup domain make master tree.

Eduardo has uploaded a new change for review.

Change subject: Renamed backup domain make master tree.
......................................................................

Renamed backup domain make master tree.

Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
---
M vdsm/storage/sd.py
M vdsm/storage/sp.py
2 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/214/1
--
To view, visit http://gerrit.ovirt.org/214
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Renamed backup domain make master tree.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 7: Renamed backup domain make master tree.
I'd appreciate an explanation why this is more elegant.

--
To view, visit http://gerrit.ovirt.org/214
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Renamed backup domain make master tree.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sd.py
Line 520:     def makeMasterTree(self):
makeMasterTree and createMasterTree are confusing

maybe setupMasterMount()?

--
To view, visit http://gerrit.ovirt.org/214
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Eduardo has abandoned this change.

Change subject: Renamed backup domain make master tree.
......................................................................


Patch Set 1: Abandoned

Will be back

--
To view, visit http://gerrit.ovirt.org/214
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;