Change in vdsm[master]: gluster: Enhancing glusterVolumeStatus verb to include volum...

Hello Bala.FA,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/23201

to review the following change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................

gluster: Enhancing glusterVolumeStatus verb to include volume stats info.

glusterVolumeStatus verb is enhanced to include volume stats info
along with the existing status information when the statusOption
is set as detail.

Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Signed-off-by: ndarshan <dnarayan(a)redhat.com&gt;
---
M vdsm/gluster/api.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/23201/1

diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 3cc5493..62c7ba9 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -208,6 +208,16 @@
                      options=None):
         status = self.svdsmProxy.glusterVolumeStatus(volumeName, brick,
                                                      statusOption)
+        if statusOption == 'detail':
+            statvfsData = self.svdsmProxy.glusterVolumeStatsInfoGet(volumeName)
+            total = ((statvfsData.f_blocks -
+                      (statvfsData.f_bfree - statvfsData.f_bavail)) *
+                     statvfsData.f_bsize)
+            free = statvfsData.f_bavail * statvfsData.f_bsize
+            used = total - free
+            status['volumeStatsInfo'] =  {'total': str(total),
+                                          'free': str(free),
+                                          'used': str(used)}
         return {'volumeStatus': status}
 
     @exportAsVerb


-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;

Itamar Heim has abandoned this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 4:

ping

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6704/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6617/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5811/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 1: Code-Review-1

Build Unstable 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6703/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6616/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5810/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Darshan N has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5977/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6765/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6871/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 3: -Verified

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5961/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6749/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6855/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Enhancing glusterVolumeStatus verb to include volume stats info.
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5939/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6832/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6727/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf978b25fa6c09097fdfbc65937056082c5bff10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No