4:24 a.m.
Laszlo Hornyak has uploaded a new change for review.
Change subject: report idle time for multiple vcpus
......................................................................
report idle time for multiple vcpus
The idle time is now on a 0-100 scale. If the VM has multiple vcpus and
the load goes over 100%, the cpuIdle will report no further increase in
load. This patch fixes this behavior and changes the returned value to
0-(vcpus*100) scale.
Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/7892/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 3306cc2..8ff3f5a 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -164,6 +164,7 @@
return netSamples
def _getCpuStats(self, stats):
+ nrOfCpus = self._vm._dom._dom.info()[3]
stats['cpuSys'] = 0.0
sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
@@ -173,7 +174,7 @@
self._log.debug("CPU stats not available")
stats['cpuUser'] = 0.0
- stats['cpuIdle'] = max(0.0, 100.0 - stats['cpuUser'])
+ stats['cpuIdle'] = max(0.0, (100.0 * nrOfCpus) -
stats['cpuUser'])
def _getNetworkStats(self, stats):
stats['network'] = {}
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
2:16 p.m.
New subject: Change in vdsm[master]: removing cpuIdle
Dan Kenigsberg has submitted this change and it was merged.
Change subject: removing cpuIdle
......................................................................
removing cpuIdle
cpuIdle is not used by the engine, and it is wrong anyway
Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M vdsm/libvirtvm.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 1 insertion(+), 5 deletions(-)
Approvals:
Laszlo Hornyak: Verified
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Peter V. Saveliev: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
11:09 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
2:20 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Dan Kenigsberg has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
10:43 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 4574: 'network': 'NetworkInterfaceStatsMap',
Line 4575: 'disks': 'VmDiskStatsMap', 'monitorResponse':
'int',
Line 4576: 'nice': 'int', 'elapsedTime': 'uint',
'*cdrom': 'str',
Line 4577: '*boot': 'VmBootMode','statsAge':
'float', 'cpuSys': 'float',
Line 4578: 'cpuUser': 'float',
If you want to keep this thing aligned, then I would recommend to have one field
definition in a line, otherwise it will be a nightmare to maintain.
Line 4579: 'acpiEnable': 'bool', 'timeOffset':
'uint',
Line 4580: 'clientIp': 'str', 'pauseCode':
'str', 'memUsage': 'uint',
Line 4581: 'username': 'str', 'session':
'GuestSessionState',
Line 4582: 'appsList': ['str'], 'guestIPs':
'str',
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
10:27 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Shu Ming has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 4574: 'network': 'NetworkInterfaceStatsMap',
Line 4575: 'disks': 'VmDiskStatsMap', 'monitorResponse':
'int',
Line 4576: 'nice': 'int', 'elapsedTime': 'uint',
'*cdrom': 'str',
Line 4577: '*boot': 'VmBootMode','statsAge':
'float', 'cpuSys': 'float',
Line 4578: 'cpuUser': 'float',
A nit, why not keep the above line aligned with others with two or three data per line.
Line 4579: 'acpiEnable': 'bool', 'timeOffset':
'uint',
Line 4580: 'clientIp': 'str', 'pauseCode':
'str', 'memUsage': 'uint',
Line 4581: 'username': 'str', 'session':
'GuestSessionState',
Line 4582: 'appsList': ['str'], 'guestIPs':
'str',
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
7:32 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Antoni Segura Puimedon has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:20 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Peter V. Saveliev has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:19 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 4:
removed the cpuIdle from vdsmapi-schema.json (only the vm part)
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:13 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Peter V. Saveliev has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
Good then.
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:07 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 3:
in utils.py it is for the vds cpuIdle, it is actually used by the engine, but it appears
that too is incorrect, maybe it would be nice to fix it in another patch
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
6:29 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 3:
right, removing.
It was working without it :)
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
6:27 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Peter V. Saveliev has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 3: I would prefer that you didn't submit this
beside os libvirtvm.py, we have cpuIdle used at least in two files:
# grep -rnI --exclude libvirtvm.py cpuIdle . | awk -F \: '{a[$1]++} END {for (i in a)
print i": "a[i]" matches"}'
./vdsm_api/vdsmapi-schema.json: 4 matches
./vdsm/utils.py: 3 matches
I think, it is better to remove cpuIdle from there also.
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
8:13 a.m.
New subject: Change in vdsm[master]: removing cpuIdle
Laszlo Hornyak has posted comments on this change.
Change subject: removing cpuIdle
......................................................................
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
5:58 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164: return netSamples
Line 165:
Line 166: def _getCpuStats(self, stats):
Line 167: nbVirtCPU = self._vm._dom._dom.info()[3]
Done
Line 168: stats['cpuSys'] = 0.0
Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170:
Line 171: try:
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
1:39 a.m.
Mark Wu has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (1 inline comment)
I don't know what the idle time of a vm means to engine. It idle time could be caused
by low workload in guest, or not heavy load on host.
....................................................
File vdsm/libvirtvm.py
Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164: return netSamples
Line 165:
Line 166: def _getCpuStats(self, stats):
Line 167: nbVirtCPU = self._vm._dom._dom.info()[3]
anyway, a redundant ._dom, should be self._vm._dom.info()[3], right?
Line 168: stats['cpuSys'] = 0.0
Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170:
Line 171: try:
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
8:18 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 173: except (TypeError, ZeroDivisionError):
Line 174: self._log.debug("CPU stats not available")
Line 175: stats['cpuUser'] = 0.0
Line 176:
Line 177: stats['cpuIdle'] = max(0.0, (100.0 * nbVirtCPU) -
stats['cpuUser'])
http://lists.ovirt.org/pipermail/engine-devel/2012-September/002453.html - posted here,
will see...
Line 178:
Line 179: def _getNetworkStats(self, stats):
Line 180: stats['network'] = {}
Line 181: sInfo, eInfo, sampleInterval = self.sampleNet.getStats()
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:37 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 173: except (TypeError, ZeroDivisionError):
Line 174: self._log.debug("CPU stats not available")
Line 175: stats['cpuUser'] = 0.0
Line 176:
Line 177: stats['cpuIdle'] = max(0.0, (100.0 * nbVirtCPU) -
stats['cpuUser'])
Good point, I will ask the guys on the engine-devel list. I took a short look into the
engine code but it seems it is not really used. It is kept in the DB after polling the
VDSM, but not actually used for anything.
Line 178:
Line 179: def _getNetworkStats(self, stats):
Line 180: stats['network'] = {}
Line 181: sInfo, eInfo, sampleInterval = self.sampleNet.getStats()
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
7:24 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164: return netSamples
Line 165:
Line 166: def _getCpuStats(self, stats):
Line 167: nbVirtCPU = self._vm._dom._dom.info()[3]
nb? I think libvirt docs use "nr".
http://libvirt.org/html/libvirt-libvirt.html#virDomainInfo
Line 168: stats['cpuSys'] = 0.0
Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170:
Line 171: try:
Line 173: except (TypeError, ZeroDivisionError):
Line 174: self._log.debug("CPU stats not available")
Line 175: stats['cpuUser'] = 0.0
Line 176:
Line 177: stats['cpuIdle'] = max(0.0, (100.0 * nbVirtCPU) -
stats['cpuUser'])
I have a vague memory that Engine and its reports would be very sad about this change.
Please get their acks.
Line 178:
Line 179: def _getNetworkStats(self, stats):
Line 180: stats['network'] = {}
Line 181: sInfo, eInfo, sampleInterval = self.sampleNet.getStats()
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
4:41 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
4:36 a.m.
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164: return netSamples
Line 165:
Line 166: def _getCpuStats(self, stats):
Line 167: nrOfCpus = self._vm._dom._dom.info()[3]
Done
Line 168: stats['cpuSys'] = 0.0
Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170:
Line 171: try:
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
4:32 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
Line 164: return netSamples
Line 165:
Line 166: def _getCpuStats(self, stats):
Line 167: nrOfCpus = self._vm._dom._dom.info()[3]
Since the libvirt API is quite cryptic and info does not convey what information we are
getting, I would propose to change the variable name into something like in libvirt
webpage:
nbVirtCPU.
Line 168: stats['cpuSys'] = 0.0
Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats()
Line 170:
Line 171: try:
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
4276
days inactive
4283
days old
vdsm-patches@lists.fedorahosted.org
21 comments
6 participants
participants (6)
-
asegurap＠redhat.com -
Dan Kenigsberg -
lhornyak＠redhat.com -
peet＠redhat.com -
shuming＠linux.vnet.ibm.com -
wudxw＠linux.vnet.ibm.com